Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 574: * > Not sure what you mean by storing in thread local storage given that scale I meant doing something like this: http://github.mtv.cloudera.com/CDH/Impala/blob/cdh5-trunk/be/src/exprs/math-functions-ir.cc#L139 Line 599: TimestampValue tv(whole_pt, fract_pt); > Okay, if the timestamp code already handles this could you please make sure I added some new test cases. Are you suggesting to add a comment to every existing case in which the result of the cast changed because of this patch? Isn't that excessive? -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
