Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3154/5/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 581: const uint64_t LARGEST_EPOCH = 253402300799; > Let's not expose this timestamp detail outside of timestamp. If we want to I like the suggestion to check for less than min, I didn't think of that (now I know :) ). I added the test cases. http://gerrit.cloudera.org:8080/#/c/3154/5/be/src/exprs/decimal-operators.h File be/src/exprs/decimal-operators.h: Line 150: int target_scale, const DecimalRoundOp& op); > add a blank line here Done Line 151: /// Returns the fractional_part in nanosecond scale. > Document the scale parameter. Maybe something like: Done. Renamed the method and tweaked some names in the implementation. -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
