Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/3154/6//COMMIT_MSG Commit Message: Line 14: This issue : can probably be fixed with codegen. > still not clear why the code is slower. Codegen is already substituting the I'll open a JIRA once the patch goes in. http://gerrit.cloudera.org:8080/#/c/3154/6/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 602: || > nit: we generally put the || operator at the end of line 601 Done http://gerrit.cloudera.org:8080/#/c/3154/6/be/src/exprs/decimal-operators.h File be/src/exprs/decimal-operators.h: Line 152: Coverts > Converts fractional Done -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
