Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3154/3/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 583: whole_pt > maybe rename this seconds, and rename fract_pt to nanoseconds, to make the Done Line 601: int128_t > We don't have a TimestampValue(int128_t, int128_t) constructor. We know fr You're right we need a check here. It basically takes the lowest 64 bits and gets rid of the highest 64. So, for example 2^70 + 1 (1180591620717411303425) decimal returns an incorrect result (as if we passed in 1). I'll add a check that whole part is not too large. -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
