Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/3/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 601: int128_t > Thanks. Please add test cases too for the various cases, and try them befor I added several test cases to the latest patch. We are back to the same behavior as before when it comes to overflow, i.e. if you pass in a very large value, you will get NULL in this patch and before this patch. Also, the implementation before this patch allowed the resulting timestamp to be slightly larger than 9999-12-31 23:59:59. We put a limit on that in this patch. I added test cases for this. -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
