Casey Ching has posted comments on this change. Change subject: IMPALA-2336: Ignore trailing comments in non-interactive mode ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3169/3/shell/impala_shell.py File shell/impala_shell.py: Line 1178: # -- comment2 Hmm this seems like a strange thing to do. If this is allowed, I'd think -- comment ; -- comment ; -- comment would be allowed too. But that would lead to an error right? (Only the last line is valid). Also ; ; would be a valid input, so it's strange. -- To view, visit http://gerrit.cloudera.org:8080/3169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723763ef7eedd03cf22058fadf06e9673a0d94d2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-HasComments: Yes
