Michael Ho has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3259/1//COMMIT_MSG Commit Message: Line 10: the environment variable $IMPALA_TOOLCHAIN. By default, it > For some reason when I read this I thought the var would be required but th Good point. Done. http://gerrit.cloudera.org:8080/#/c/3259/1/CMakeLists.txt File CMakeLists.txt: Line 86: set(Boost_USE_MULTITHREADED OFF) > This line conflicts with line 78. I'm guessing this line is the one you wan Done http://gerrit.cloudera.org:8080/#/c/3259/1/bin/impala-config.sh File bin/impala-config.sh: Line 63: "leave it unset." > Ah I see now the default value is set above. Ignore the earlier comment... Yes, this is guarding against users explicitly setting $IMPALA_TOOLCHAIN to empty string. -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
