Casey Ching has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3259/1/bin/impala-config.sh File bin/impala-config.sh: Line 63: "leave it unset." > Yes, this is guarding against users explicitly setting $IMPALA_TOOLCHAIN t As Matt suggested this would be better if combined with line 42 -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
