Hello Casey Ching,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3259
to look at the new patch set (#4).
Change subject: IMPALA-3223: Removal of non-toolchain builds.
......................................................................
IMPALA-3223: Removal of non-toolchain builds.
This change removes the option to build without specifying
the environment variable $IMPALA_TOOLCHAIN. By default, if
it's not set, sourcing impala-config.sh will set it to
$IMPALA_HOME/toolchain. A user can override it by setting
$IMPALA_TOOLCHAIN to his/her own toolchain directory and
setting $SKIP_TOOLCHAIN_BOOTSTRAP to true to avoid the
directory from being overwritten by the toolchain boostrapping
script.
$IMPALA_TOOLCHAIN holds some third party binaries which
Impala relies on. They can be compiled from source in the
native toolchain which is public. This commit doesn't yet
do a comprehensive check to verify that all necessary
components exist in the toolchain directory and that's
a future task.
By default, Impala will be built with the compiler in
$IMPALA_TOOLCHAIN but this option can be overridden by
setting environment variable $USE_SYSTEM_GCC to 1.
Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
---
M CMakeLists.txt
M be/CMakeLists.txt
M bin/impala-config.sh
D cmake_modules/FindPICLibs.cmake
M cmake_modules/asan_toolchain.cmake
M cmake_modules/toolchain.cmake
6 files changed, 103 insertions(+), 187 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/59/3259/4
--
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
