Michael Ho has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 5: (1 comment) There are more cleanups found in buildall.sh. Included that in the latest patch. http://gerrit.cloudera.org:8080/#/c/3259/5/bin/impala-config.sh File bin/impala-config.sh: PS5, Line 261: IMPALA_AVRO_VERSION+=-p4 : IMPALA_BZIP2_VERSION+=-p1 : IMPALA_GLOG_VERSION+=-p1 : IMPALA_THRIFT_VERSION+=-p8 : IMPALA_RE2_VERSION+=-p1 : IMPALA_LLVM_VERSION+=-p1 : IMPALA_LLVM_ASAN_VERSION+=-p1 : # Debug builds should use the release+asserts build to get additional coverage. : # Don't use the LLVM debug build because the binaries are too large to distribute. : IMPALA_LLVM_DEBUG_VERSION+=-asserts-p1 > These don't need to be appended separately from their original definitions Separating them make it easier to see which ones are patched but It makes it harder to read the actual version string. Fixed in new patch. -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
