Michael Ho has posted comments on this change.

Change subject: download_requirements should download kudu-python and virtualenv
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3217/1/infra/python/deps/download_requirements
File infra/python/deps/download_requirements:

Line 17: "$PIP" install --download "$DIR" --no-use-wheel \
> The only reason is that there's some logic in infra/python/bootstrap_virtua
In theory, we should able to handle wheel files too as they are just zipped 
archive. That said, it's probably not worth the trouble to complicate the 
boostrap_virtualenv.py to detect the file type and handle them accordingly.


-- 
To view, visit http://gerrit.cloudera.org:8080/3217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to