Casey Ching has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv ......................................................................
Patch Set 2: > This is one of the fixes blocking IMPALA-3223: Make git.apache.org > code buildable. I'd rather avoid investing too much time into > improving this script when it already works ok. Not sure that > trying to parse JSON in a shell script is worth it. Maybe ask Micheal for his opinion. If he's ok with it then it's fine with me. I wouldn't check this in but maybe that's just me. -- To view, visit http://gerrit.cloudera.org:8080/3217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
