Casey Ching has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv ......................................................................
Patch Set 2: > It doesn't look like the hash is optional. E.g. > https://pypi.python.org/packages/virtualenv-15.0.2.tar.gz > doesn't work. I don't see a way to directly download the packages > aside from including the full download URL for that specific > version, which would mean updating URL for every version change. > > It seems like --download is meant to just download the package but > for whatever reason it's not behaving as documented in these case. Oh I thought you meant the md5 hash. Looks like there is https://pypi.python.org/pypi/virtualenv/15.0.2/json. I guess you can parse that if you want to dynamically find the url. You might want to look into why Kudu is attempting installation, that seems like a bug. -- To view, visit http://gerrit.cloudera.org:8080/3217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
