Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3217/1/infra/python/deps/download_requirements File infra/python/deps/download_requirements: Line 28: echo "kudu-python install failed. This is expected if we do not yet have an installed"\ > pip download isn't available on my system (Ubuntu 15.10) so it's probably n I also looked into it more, and it looks like pip is running "python setup.py egg_info" after downloading, not actually building the package. But the setup.py script for kudu-python wants to set up all of the library, include, etc paths required for the build. It's not really clear to me whether the bug is in kudu-python's setup.py or whether Impala's build dependencies between the toolchain and the python virtualenv are making it complicated. -- To view, visit http://gerrit.cloudera.org:8080/3217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
