Yuanhao Luo has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 826: } > Please avoid this CopyFrom if at all possible. Perhaps make both functions Sorry, I don't understand what do you mean by "make both functions wrappers around a different interface", which two functions and wrappers what? -- To view, visit http://gerrit.cloudera.org:8080/3244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
