Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding-test.cc File be/src/util/url-coding-test.cc: Line 49: bool Base64Decode(const string& in, string* out) { This is a near-copy of StringFunctions::Base64Decode. Please do not do that, anywhere in this or any other patch. Please figure out a way to make one function that you can call in multiple contexts, not two functions that have near-identical source code. http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding.h File be/src/util/url-coding.h: Line 42: bool Base64Length(const int in_len, unsigned* out_max); The name out_max doesn't make sense out of context. How about out_len? Line 44: /// Returns true if encoded successfully, otherwise false. Please document the parameters. -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
