Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3311/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 808: std::function<char* (unsigned)> allocator = [&](unsigned size)->char* { > I don't think breaks this up to two functions is a good idea, since that we I disagree. In particular: 1. std::functions can be heavyweight. This interface would need some refactoring anyway (don't cature entire environment by reference, use auto, document interface in function signature of impala::Base64Encode) 2. It's not a problem that, in your words, "we just need few lines to calculate the length of the encoded string". It's OK to have short functions. http://gerrit.cloudera.org:8080/#/c/3311/2/be/src/util/url-coding-test.cc File be/src/util/url-coding-test.cc: Line 55 > Do you mean I should add a base64decode function in this file just for tes I mean you can add a base64decode function for testing. -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
