Yuanhao Luo has posted comments on this change.

Change subject: IMPALA-2878: Remove unused function and duplicate codes.
......................................................................


Patch Set 1:

I have tried hours to remove redundant string copy from previous patch, 
including lambda expression of c++11 and call back function. However, it's a 
little bit hard for me. Even though it works finally, I have messed code up. So 
I rewrite this patch which is easy to understand and removes code redundant as 
possible as I can. Besides, I make a mistake to push a new changes request, I 
have abandoned the last one, sorry about that.

-- 
To view, visit http://gerrit.cloudera.org:8080/3311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <[email protected]>
Gerrit-Reviewer: Yuanhao Luo <[email protected]>
Gerrit-HasComments: No

Reply via email to