David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3301/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: PS2, Line 51: fq_table_name = '.'.join([unique_database, request.node.name]) > We need to make sure that request.node.name is a valid Impala identifier, b It looks like there's a length limit of 127. Is that 127 for the database name, and another 127 for the table name? Or does the fully qualified name ("db.table") need to be under 127? I'm presuming it's the former. PS2, Line 53: request.instance.execute_query(stmt) > We want this to succeed in all cases, and we should fail if it doesn't. The Done PS2, Line 74: request.instance.execute_query(stmt) > Same thing here: we want this to succeed. Done PS2, Line 78: class TestImpalaShell(ImpalaTestSuite): > Can you double check with Ishaan that making this inherit now is OK? Since OK, will do. (I should probably add him as a reviewer anyway.) -- To view, visit http://gerrit.cloudera.org:8080/3301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
