David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3301/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: PS2, Line 51: fq_table_name = '.'.join([unique_database, request.node.name]) > We need to make sure that request.node.name is a valid Impala identifier, b Ah, never mind. I see that you meant just the table name. -- To view, visit http://gerrit.cloudera.org:8080/3301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
