Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 27: (4 comments) http://gerrit.cloudera.org:8080/#/c/3081/27/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 95: void TEST_BYTESWAP_SSSE3_UNIT() { Our function naming convention IsLikeTis, NOT_LIKE_THIS, here and below. Line 105: ASSERT_EQ(dst_buf[j], buf_size - j - 1); Why ASSERT, not EXPECT, here and below. Line 113: const int buf_size = 32; Again, this is too much copying. The only thing different between these two functinos is buf_size, the CpuInfo expectation, and which CyteSwap. Make them parameters. Line 130: int buf_size = 64; As above, too much copying between this and the ..._AVX2_ONLY method right below this one. And the SIMD method below that one, too. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 27 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
