Dan Hecht has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads ......................................................................
Patch Set 4: (1 comment) Sorry this got stuck in my "drafts". http://gerrit.cloudera.org:8080/#/c/3313/4/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 431: return Status::OK(); can't this block be moved outside of the lock, and then you can put the Close() call here? cached_buffer_ is read on line 436 so it must not be necessary to hold the lock for this check, right? -- To view, visit http://gerrit.cloudera.org:8080/3313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
