Michael Brown has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3313/6//COMMIT_MSG Commit Message: PS6, Line 13: endup Typo: "endup" http://gerrit.cloudera.org:8080/#/c/3313/6/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl: PS6, Line 88: <value>1073741824</value> Is this a reasonable default value for our minicluster, or is this needed only for test_hdfs_caching_fallback_path ? Note this is much larger. What are the risks in changing this? Also, as you stated privately, this requires a ulimit -l change on Jenkins slaves and desktop machines. Let's be sure this is the right way to go. http://gerrit.cloudera.org:8080/#/c/3313/6/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: PS6, Line 105: get_random_id(5)) Instead of this, you could use the "testid_checksum" fixture, along with a prefix. This is also how unique_database gets its name. Or you could even cheat and use the unique_database string directly. PS6, Line 114: execute_query execute_query_expect_success() here and in other places? -- To view, visit http://gerrit.cloudera.org:8080/3313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
