Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3313/5/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: PS5, Line 96: @pytest.mark.execute_serially > does it need to run serially or would unique_database be enough? Sorry forgot about the unique_db fixture. Added it now. This isn't required anymore. PS5, Line 113: /test-warehouse/tpch.orders/*.tbl > this should also have get_fs_path (though in practice it won't matter) Done PS5, Line 130: __cleanup() > [Disclaimer: still figuring stuff out here, so apologies in advance if my c Oops, I forgot about the unique db fixture. Added it and refactored the cleanup. made it a try-except-finally. Thanks David. -- To view, visit http://gerrit.cloudera.org:8080/3313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-HasComments: Yes
