Henry Robinson has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/3371/13/fe/src/main/java/com/cloudera/impala/catalog/Catalog.java File fe/src/main/java/com/cloudera/impala/catalog/Catalog.java: PS13, Line 175: if (matcher == null) return Collections.emptyList(); > I believe Henry's comment has broader implications than simply pushing the Yes, that's exactly right, thanks! I'm sorry if this undoes some of the previous work you've done. The benefit is that we would not need this logic here to check for a null matcher. Special cases like that are always more risky, and harder for the reader to reason about. PS13, Line 334: private > then the same may apply to filterCatalogObjectsByPattern(), but it accesses The same doesn't apply to filterCatalogObjectsByPattern(), because a CatalogObject is a concept that lives in the catalog. This method operates only on strings. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
