Henry Robinson has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 16: (1 comment) Getting there. http://gerrit.cloudera.org:8080/#/c/3371/16/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS16, Line 74: null pattern matches nothing while empty pattern matches all. I really, really think it would be better to have class-wide constants that encode these meanings: PatternMatcher.MATCH_ALL PatternMAtcher.MATCH_NONE They can be the same for both JDBC and Hive pattern matchers, because they can then be translated into the right regex by the builder -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 16 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
