Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/3371/15/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS15, Line 74: * Null pattern's matching is controlled by 'isNullMatchAll', where if it is set then : * null matches everything; unset otherwise. > We should be able to eliminate this parameter. Users of this API should alw if I understand correctly. this depends on we have a pattern that matches none, but we do not before this patch. there is simply no pattern string that matches none in the old code: both null and empty are treated as match all. PS15, Line 78: isNullMatchAll > can you point out where this is set to true? It is not set to true in any place. You think we can just remove this option? I do not know if this is a standard in JDBC pattern. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 15 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
