Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 17: (2 comments) there are lot of changes to test. so just make sure the new API looks good to you... Henry. thank you! http://gerrit.cloudera.org:8080/#/c/3371/16/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS16, Line 74: or (String pattern: Arrays.asList(hivePattern.split("\\|"))) > I really, really think it would be better to have class-wide constants that Done http://gerrit.cloudera.org:8080/#/c/3371/17/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS17, Line 48: public static final String JDBC_MATCH_ALL_PATTERN = "%"; : public static final String HIVE_MATCH_ALL_PATTERN = null; : public static final String MATCH_NONE_PATTERN = ""; : : public boolean hasPattern() { return patterns_ != null; } : : public static String getJDBCPattern(String pattern) { : if (pattern == null || pattern.isEmpty()) return JDBC_MATCH_ALL_PATTERN; : return pattern; does this change look good? I can have another getHivePattern(String) to return valid String so that I can have hivePattern in createHivePatternMatcher() to be not null(include in a precondition check). User has to call this getxxxxPattern() in metadataOp.java in order to convert pattern string early. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 17 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
