Henry Robinson has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 18: (3 comments) Getting very close. Please make the changes you've highlighted as well. http://gerrit.cloudera.org:8080/#/c/3371/18/fe/src/main/java/com/cloudera/impala/catalog/Db.java File fe/src/main/java/com/cloudera/impala/catalog/Db.java: PS18, Line 432: If matcher is null, return an empty list. Update comment as well? http://gerrit.cloudera.org:8080/#/c/3371/18/fe/src/main/java/com/cloudera/impala/service/Frontend.java File fe/src/main/java/com/cloudera/impala/service/Frontend.java: PS18, Line 614: If 'matcher' is null, returns an empty list. Update comment http://gerrit.cloudera.org:8080/#/c/3371/18/fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java File fe/src/main/java/com/cloudera/impala/util/PatternMatcher.java: PS18, Line 46: public static final PatternMatcher MATCHER_MATCH_ALL = new PatternMatcher(); : public static final PatternMatcher MATCHER_MATCH_NONE; : static { : MATCHER_MATCH_NONE = new PatternMatcher(); : MATCHER_MATCH_NONE.patterns_ = Collections.emptyList(); : } One problem here is that this requires that PatternMatcher remains thread safe (as many threads may use these objects). I think it's better to have: static PatternMatcher createMatchAllMatcher(); OR static string PatternMatcher MATCH_ALL_PATTERN = "<...something...>"; given this patch, I think the first is better. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 18 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
