Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 28: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/28/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 95: void TestByteswapSimdUnit(FuncPointer BytewapFunc, const int64_t CpuFlag) { Please explain all function parameters. Line 101: if (CpuFlag == CpuInfo::SSSE3) { If you only ever test the SSSE3 function with 16 and the AVX2 functino with 32, do you really need two parameters? Line 119: void TestByteswapSimd(const int64_t CpuFlag, const int start_size, const int buf_size) { Please give this function a comment, and please explain all parameters. Line 169: if (LIKELY(CpuInfo::IsSupported(CpuInfo::SSSE3))) { If the meachine that this tst is running on supports AVX2 and SSSE3, please test both. Please test all methods that can be tested on the test machine. PS28, Line 180: comprehensively This doesn't test "comprehensively", it just tests the non-SIMD version. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 28 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
