Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 29: (4 comments) http://gerrit.cloudera.org:8080/#/c/3081/28/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 169: EXPECT_EQ(BitUtil::ByteSwap(static_cast<int32_t>(0)), 0); > Done This doesn't look done to me. In the AVX case, it looks like only SSSE3 code is not tested http://gerrit.cloudera.org:8080/#/c/3081/29/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 99: // CpuInfo::AVX2 for ByteSwapAVX2_Unit; In our codebase, function parameters are explained before the function name, not in the body. Here and below. Line 106: } else if (CpuFlag == CpuInfo::AVX2) { ASSERT_EQ, not 'else if', since there is no other choice. Here and below. http://gerrit.cloudera.org:8080/#/c/3081/29/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 166: typedef void (*FuncPointer)(uint8_t* dst, const uint8_t* src); Please don't pollute the impala namespace with a typedef with a name this generic. Generally, anything that you don't absolutely need to be exposed should be in namespace internal or namespace detail. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 29 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
