Kathy Sun has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ......................................................................
Patch Set 2: (4 comments) > (4 comments) Oops.. fixed them. Tim, how could you even notice there is a space after a line... Is there a code style detector or something like that? http://gerrit.cloudera.org:8080/#/c/3664/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS2, Line 252: ince > since Done PS2, Line 263: else > need space before else Done http://gerrit.cloudera.org:8080/#/c/3664/1/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: PS1, Line 136: > Let's remove the extra whitespace at end of line. Done Line 138: rapidjson::Document* output); > We usually indent wrapped lines 4 spaces Done -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
