Henry Robinson has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ......................................................................
Patch Set 3: (6 comments) Looks pretty good, just one thing I think you could improve. http://gerrit.cloudera.org:8080/#/c/3664/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: Line 31: #include "runtime/mem-tracker.h" please order alphabetically (and fix up the other headers that are out of order:)) PS3, Line 249: server_->GetQueryExecState(unique_id, true); indent by four chars only PS3, Line 256: const string& err = Substitute("Invalid query id: $0", PrintId(unique_id)); : Value json_error(err.c_str(), document->GetAllocator()); When you click on this tab with a finished query, won't it just show the error message without the tabs? If so, I think we can do better - instead of using the generic error message template, let's add a message saying "Memory information only available for running queries" and print that in an alert box under the tabs, i.e. special case it for this page. PS3, Line 254: lock_guard<mutex> l(*exec_state->lock(), adopt_lock_t()); : if (exec_state->coord() == NULL) { : const string& err = Substitute("Invalid query id: $0", PrintId(unique_id)); : Value json_error(err.c_str(), document->GetAllocator()); : document->AddMember("error", json_error, document->GetAllocator()); : return; : } : MemTracker* query_mem_tracker = exec_state->coord()->query_mem_tracker(); : mem_usage_text = query_mem_tracker->LogUsage(); indentation should be two chars here PS3, Line 270: d fix indentation http://gerrit.cloudera.org:8080/#/c/3664/3/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: Line 136: // Returns memory usage for queries inflight. in flight -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
