Tim Armstrong has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3664/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS1, Line 244: _str(), > I do think c_str() is needed. I remember removing it will have compile erro Hmm, you're right, it looks like our version of rapidjson doesn't support string arguments. http://gerrit.cloudera.org:8080/#/c/3664/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS2, Line 252: ince since PS2, Line 263: else need space before else http://gerrit.cloudera.org:8080/#/c/3664/2/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: Line 136: // Returns memory usage for queries inflight. You missed fixing my comments in this file. -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
