Tim Armstrong has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3664/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: Line 254: lock_guard<mutex> l(*exec_state->lock(), adopt_lock_t()); Also there's 4 spaces indent here instead of 2. Line 264: mem_usage_text = "The query is finished, current memory consumption is not available."; > Missed the long line here. Should be 90 characters or less. 4 spaces indent -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
