Henry Robinson has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: PS4, Line 255: Invalid query id: $0" This would be better as something like "Query $0 does not have memory tracking information available". The ID is not invalid but the query doesn't have the information you want. And to my point on the last review round: this could happen for, for example, an EXPLAIN query. Why not just set mem_usage_text here and treat all error cases the same? PS4, Line 263: indentation is 4 chars here and should be 2. -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86db096ab7a022d230018becdb60bcc3056847af Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
