Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3311/6/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 110: if (in_len < 0 || *out_max > static_cast<unsigned>(std::numeric_limits<int>::max())) formatting (and elsewhere) http://gerrit.cloudera.org:8080/#/c/3311/6/be/src/util/url-coding.h File be/src/util/url-coding.h: Line 15: #ifndef UTIL_URL_CODING_H let's rename this to coding-utils or something like that Line 42: bool Base64EncodeBufLen(const int in_len, unsigned* out_max); no need for const int, int is sufficient. however, all lengths should be passed as int64. we also don't use unsigned integer types, unless for bitvectors. please apply in following function as well. Line 47: bool Base64Encode(const char* in, const int in_len, char* out, unsigned out_max, all output parameters go to the end -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
