Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3311/3/be/src/util/url-coding-test.cc File be/src/util/url-coding-test.cc: Line 49: bool Base64Decode(const string& in, string* out) { > Really sorry, but I don't understand what do you mean by "add a base64deco ou could have one function that both this file and StringFunctions:: use, or you could use StringFunctions:: version here without copying it. -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
