Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3311
to look at the new patch set (#6).
Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
......................................................................
IMPALA-2878: Fix Base64Decode error and remove duplicate codes.
Original impala::Base64Decode() method wouldn't return original string if
there were trailing '\0'. For example, string "a\0" would be encoded into
"YQA=", while calling original Base64Decode() method, the return value
is "a", which losts the trailing '\0' of original string "a\0". Besides,
this commit remove duplicate codes of function impala::Base64En/Decode()
and impala::StringFunctions::Base64En/Decode().
Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
---
M be/src/exprs/string-functions-ir.cc
M be/src/util/url-coding-test.cc
M be/src/util/url-coding.cc
M be/src/util/url-coding.h
4 files changed, 99 insertions(+), 70 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/11/3311/6
--
To view, visit http://gerrit.cloudera.org:8080/3311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Yuanhao Luo <[email protected]>
