Thomas Tauber-Marshall has uploaded a new patch set (#3).

Change subject: IMPALA-3924: Ubuntu16 support
......................................................................

IMPALA-3924: Ubuntu16 support

One problem uncovered while trying to build Impala on Ubuntu16 is
that the functions 'isnan' and 'isinf' both appear in std::
(from <math.h>) and in boost::math::, but we're currently using
them without qualifiers in several places, leading to a conflict.

This patch prefaces all uses with 'std::' to disambiguate, and also
adds <math.h> imports to all files that use those functions, for
the sake of explicitness.

Another problem is that bin/make_impala.sh uses the system cmake,
which may not be compatible with the toolchain binaries. This patch
updates make_impala.sh to use the toolchain version of cmake.

Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
---
M be/src/exprs/cast-functions-ir.cc
M be/src/exprs/udf-builtins-ir.cc
M be/src/runtime/raw-value-ir.cc
M be/src/runtime/raw-value.inline.h
M be/src/util/metrics-test.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/make_impala.sh
8 files changed, 24 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/3800/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>

Reply via email to