Jim Apple has posted comments on this change. Change subject: IMPALA-3924: Ubuntu16 support ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3800/3//COMMIT_MSG Commit Message: PS3, Line 11: <math.h> I think in C++ <cmath> is the way to reference that file, and the same for cstdint and cstdio and so on. Those, as I understand it, put their identifiers in ::std:: -- To view, visit http://gerrit.cloudera.org:8080/3800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
