Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3924: Ubuntu16 support ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3800/3//COMMIT_MSG Commit Message: PS3, Line 11: <cmath>) > I think in C++ <cmath> is the way to reference that file, and the same for Done http://gerrit.cloudera.org:8080/#/c/3800/3/bin/impala-config.sh File bin/impala-config.sh: PS3, Line 310: export PATH=$IMPALA_HOME/bin:$IMPA > Let's actually add our cmake to the path rather than using the CMAKE_CMD va Done http://gerrit.cloudera.org:8080/#/c/3800/3/bin/make_impala.sh File bin/make_impala.sh: PS3, Line 29: > let's remove this here and instead put this directory in the PATH, see my c Done -- To view, visit http://gerrit.cloudera.org:8080/3800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
