David Knupp has uploaded a new patch set (#3).
Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of
Impala LZO.
......................................................................
IMPALA-3898: Add a pytest skipif decorator based on presence of Impala
LZO.
As part of shoring up the build/test procedure for the ASF initiative,
if Impala LZO isn't present, we want to skip tests that would otherwise
fail without it. Rather than adding a bunch of pytest skip* decorators
to existing tests, instead just create an autouse fixture in the
pytest conftest.py file. This fixture will automatically always get
invoked with any test, and in case ${IMPALA_LZO}/build/libimpalalzo.so
does not exist, it will skip tests where the test vector contains
compression_codec: lzo.
* There is one test in data_errors (test_hdfs_scan_node_errors) that
will always fail without Impala LZO, so a specific skipif decorator
was added in that instance.
Also, minor PEP-8 improvements were made in various files.
Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
---
M tests/common/environ.py
M tests/conftest.py
M tests/data_errors/test_data_errors.py
3 files changed, 59 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/3782/3
--
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
