Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3782/2/tests/common/environ.py File tests/common/environ.py: Line 256: if impala_lzo_root is not None: This returns True, False, or None. Can it just return True or False? Also, can this just be 'if impala_lzo_root:'? PS2, Line 257: if os.path.isfile(os.path.join(impala_lzo_root, 'build', 'libimpalalzo.so')): : return True : return False if X: return True return False is equivalent to return X right, as long as X is always True or False? http://gerrit.cloudera.org:8080/#/c/3782/2/tests/conftest.py File tests/conftest.py: Line 188: # a StopIteration exception is thrown. This is most assuredly a bug in the Should you catch only StopIteration exceptions, then? Not being Socratic, really asking. http://gerrit.cloudera.org:8080/#/c/3782/2/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS2, Line 41: why this is DataErrorsTest/hdfs-scan-node-errors.test, online 75, references LZO. Maybe you could take that test out of that file and put it in a separate test case in this one. -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
