Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error when a Parquet file has no row groups. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 856: } > I'm not opposed to handling _more_ errors like this, it just wasn't obvious the error handle for all of these would be the same, right? so i think we can reasonable test coverage with just a couple of example bad files. (of course, exercising all paths is best, but i don't see that as a pre-req for this change). and better to put the code where it belongs, otherwise other code readers will sit puzzled like I was about why this case was so special. -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
