Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS5, Line 183: if (!status.ok()) return state_->LogOrReturnError(status.msg()) I don't understand why we expect this to work if the file_metadata_ and column_readers_ was never set but we return OK. It looks to me like we'd index into garbage in GetNextInternal() when we index into column_readers_[0] which was never populated by Open(). Perhaps I'm missing something though? I'd think we'd want a way to explicitly short circuit return from GetNextInternal(), which is I think what Tim was suggesting originally (before we went with the more surgical fix, and then obviously now we've backed out). -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
