Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error when a Parquet file has no row groups. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS1, Line 178: if (!status.ok()) RETURN_IF_ERROR(state_->LogOrReturnError(status.msg())); > Done As Tim pointed out, it doesn't seem like this would work in all cases since the metadata will be in some weird state. Seems we should short-circuit this. -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
