Alex Behm has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error when a Parquet file has no row groups. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 856: } > One could argue that empty row group should only be a warning (i.e. regardl I moved this check to the caller to handle more cases. I modified existing tests to run with both values of abort_on_error. They do not provide 100% coverage of all cases within ProcessFooter(), but certainly a few important ones. Fixing and testing all possible scenarios with corrupt data files and making all error cases adhere to abort_on_error feels beyond the scope of this patch. I think we should focus our time and efforts on more pressing matters first. -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aff766a1ce6376efb329bdde51c648149dfe08c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
