Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3629: Codegen TransferScratchTuples() in 
hdfs-parquet-scanner
......................................................................


Patch Set 7: Code-Review+1

Some performance numbers from the latest version:

codegen1 = 'select * from tpch_parquet.lineitem'
codegen2 = 'select * from tpch_parquet.lineitem where l_orderkey < 600001 and 
l_partkey > -1 and l_suppkey < 10001 and l_linenumber > 0'

 
+-----------------+-----------------------+---------+------------+------------+----------------+
 | Workload        | File Format           | Avg (s) | Delta(Avg) | GeoMean(s) 
| Delta(GeoMean) |
 
+-----------------+-----------------------+---------+------------+------------+----------------+
 | TARGETED-PERF() | parquet / none / none | 12.28   | -13.84%    | 7.39       
| -13.38%        |
 
+-----------------+-----------------------+---------+------------+------------+----------------+

 
+-----------------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
 | Workload        | Query    | File Format           | Avg(s) | Base Avg(s) | 
Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters |
 
+-----------------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
 | TARGETED-PERF() | codegen2 | parquet / none / none | 2.48   | 2.84        |  
 -12.79%  |   1.36%   |   1.15%        | 1           | 3     |
 | TARGETED-PERF() | codegen1 | parquet / none / none | 22.07  | 25.65       |  
 -13.95%  |   0.15%   |   0.04%        | 1           | 3     |
 
+-----------------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+

-- 
To view, visit http://gerrit.cloudera.org:8080/3774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to