Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS7, Line 162: codegend_process_scratch_batch_fn_ = reinterpret_cast > Is this check redundant as GetCodegenFn() should return NULL if codegen is Done PS7, Line 553: // > nit: 2 more spaces Done PS7, Line 585: > Did you mean to use these to replace some constants ? They don't seem to be Done http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: PS7, Line 469: Processes a single row batch for TransferScratchTuples, looping over scratch_b > Not really clear how this fn is different from TransferScratchTuples or why Done http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS7, Line 558: *write_complete_tuple_fn = codegen->FinalizeFunction(fn); : if (*write_complete_ > Doesn't this trigger the DCHECK in some code which check the returned funct Done http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-sequence-scanner.cc File be/src/exec/hdfs-sequence-scanner.cc: PS7, Line 63: writ > nit: wrong indentation Done http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS7, Line 699: DCHECK(*write_aligned_tuples_fn != NULL); > Please see comments in CodegenWriteAlignedTuples() about this DCHECK(). Done -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
